CodeAnalysis/AssignmentInTernaryCondition: add XML documentation#2678
Merged
jrfnl merged 1 commit intoFeb 2, 2026
Merged
Conversation
rodrigoprimo
changed the title
jrfnl
reviewed
Jan 27, 2026
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
@rodrigoprimo Thanks for picking this one up. Looking good. Left a couple of comments for you to think over.
rodrigoprimo
force-pushed
the
docs-assignment-in-ternary-condition
branch
from
ae710d0 to
e6d3ed4
Compare
Contributor
Author
|
Thanks for your review, @jrfnl. I believe I addressed all the points you raised, and this PR is ready for another check. |
jrfnl
approved these changes
Jan 29, 2026
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Thanks @rodrigoprimo ! I believe this one is also ready for merge 🎉
Member
|
Note for the second reviewer: please squash-merge this PR. |
dingo-d
requested changes
Jan 30, 2026
Member
dingo-d
left a comment
dingo-d
left a comment
There was a problem hiding this comment.
Just one minor grammar quirk that stood out to me.
dingo-d
approved these changes
Feb 2, 2026
Co-authored-by: Nic <Nic-Sevic@users.noreply.github.com> Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com> Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>
rodrigoprimo
force-pushed
the
docs-assignment-in-ternary-condition
branch
from
fbecb2c to
54e4f11
Compare
Contributor
Author
|
Just noting that I squashed the commits in this PR. I believe it is ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds XML documentation for the
WordPress.CodeAnalysis.AssignmentInTernaryConditionsniff.The documentation is based on the work started by @Nic-Sevic in #2488. I squashed the original commits and, in a separate commit, made subsequent changes based on the review left in #2488.
I suggest squashing those two commits before merging. I'm opening the PR without doing that to make it easier to tell my changes apart from the original changes.
Suggested changelog entry
N/A
Related issues/external references
Related to: #1722
Supersedes: #2488
Closes #2488